fix: acknowledge signed payment notice before querying provider

digital-avatar-app/backend/main.py

@@ -320,7 +320,7 @@ def start_maintenance_scheduler():
     )
     maintenance_scheduler.add_job(
         reconcile_huihui_org_notices_job,
-        trigger=IntervalTrigger(seconds=30),
+        trigger=IntervalTrigger(seconds=10),
         id="reconcile_huihui_org_notices",
         max_instances=1,
         coalesce=True,

digital-avatar-app/backend/routers/tokens.py

@@ -896,19 +896,10 @@ def _process_huihui_org_notice(payload: dict, db: Session):
         raise HTTPException(status_code=409, detail="payment number conflicts with prior notice")
     if not order.provider_order_no:
         raise HTTPException(status_code=422, detail="provider order number missing")
-    if not user.huihui_token or not user.huihui_user_id:
-        _save_huihui_org_notice(db, order, payment_no, amount_cents, expected_product_id, "unavailable")
-        return ok({"received": True, "paid": False, "awaitingProvider": True})
-    try:
-        provider_status = _huihui_org_provider_status(order, user, expected_product_id, payment_no)
-    except HuihuiPaymentError:
-        _save_huihui_org_notice(db, order, payment_no, amount_cents, expected_product_id, "unavailable")
-        return ok({"received": True, "paid": False, "awaitingProvider": True})
-    if provider_status not in {2, 3, 4}:
-        _save_huihui_org_notice(db, order, payment_no, amount_cents, expected_product_id, str(provider_status))
-        return ok({"received": True, "paid": False, "awaitingProvider": True})
-    _settle_verified_huihui_org_order(db, order, payment_no, notice)
-    return ok({"received": True, "paid": True})
+    # The provider may not mark its order paid until it receives our HTTP 200.
+    # Never synchronously query the provider before acknowledging a signed notice.
+    _save_huihui_org_notice(db, order, payment_no, amount_cents, expected_product_id)
+    return ok({"received": True, "paid": False, "awaitingProvider": True})
 
 
 def _huihui_org_provider_status(order: TokenPaymentOrder, user: User, product_id: str, payment_no: str) -> int:
@@ -936,7 +927,7 @@ def _huihui_org_provider_status(order: TokenPaymentOrder, user: User, product_id
 
 def _save_huihui_org_notice(
     db: Session, order: TokenPaymentOrder, payment_no: str, amount_cents: int,
-    product_id: str, provider_status: str,
+    product_id: str,
 ) -> None:
     notice = db.get(HuihuiOrgPaymentNotice, order.order_no)
     if notice and (
@@ -952,10 +943,11 @@ def _save_huihui_org_notice(
         )
         db.add(notice)
     notice.status = "awaiting_provider"
-    notice.last_provider_status = provider_status
+    notice.last_provider_status = "not_checked"
     notice.last_error = ""
-    notice.attempts = int(notice.attempts or 0) + 1
-    notice.next_check_at = datetime.utcnow() + timedelta(seconds=_huihui_notice_retry_seconds(notice.attempts))
+    first_check = datetime.utcnow() + timedelta(seconds=5)
+    if notice.next_check_at is None or notice.next_check_at > first_check:
+        notice.next_check_at = first_check
     try:
         db.commit()
     except IntegrityError:

digital-avatar-app/backend/tests/test_takeover_scheduler.py

@@ -61,7 +61,7 @@ def test_scheduler_uses_boxim_and_restart_safe_service(
     assert close_orders_call.kwargs["trigger"].interval.total_seconds() == 60
     assert reconcile_call.args[0] is main.reconcile_huihui_org_notices_job
     assert reconcile_call.kwargs["id"] == "reconcile_huihui_org_notices"
-    assert reconcile_call.kwargs["trigger"].interval.total_seconds() == 30
+    assert reconcile_call.kwargs["trigger"].interval.total_seconds() == 10
     maintenance_scheduler.start.assert_called_once_with()
 
     assert scheduler.add_job.call_count == 2

digital-avatar-app/backend/tests/test_virtual_payment_flow.py

@@ -133,26 +133,30 @@ def test_huihui_org_callback_verifies_provider_before_granting_points(authorizat
         pending = send(payload, callback_path=legacy_path)
         assert pending.status_code == 200
         assert pending.json()["data"] == {"received": True, "paid": False, "awaitingProvider": True}
+        provider.get_order.assert_not_called()
         db = SessionLocal()
         try:
             assert db.get(HuihuiOrgPaymentNotice, order_no).status == "awaiting_provider"
             assert db.query(TokenPaymentOrder).filter(TokenPaymentOrder.order_no == order_no).one().status == "pending"
         finally:
             db.close()
-        provider.get_order.return_value = {**provider_data, "payStatus": 2}
         assert send({**payload, "paymentNo": "wrong"}).status_code == 409
-        provider.get_order.return_value = {**provider_data, "payStatus": 2, "chargeAmount": 2}
-        assert send(payload).status_code == 422
-        provider.get_order.return_value = {**provider_data, "payStatus": 2}
         db = SessionLocal()
         try:
             notice = db.get(HuihuiOrgPaymentNotice, order_no)
             notice.next_check_at = datetime.utcnow() - timedelta(seconds=1)
             db.commit()
             from routers.tokens import reconcile_huihui_org_notices
+            provider.get_order.return_value = {**provider_data, "payStatus": 2, "chargeAmount": 2}
+            assert reconcile_huihui_org_notices(db) == 0
+            assert db.get(HuihuiOrgPaymentNotice, order_no).status == "rejected"
+            assert db.query(TokenPaymentOrder).filter(TokenPaymentOrder.order_no == order_no).one().status == "pending"
+            assert send(payload).status_code == 200
+            notice.next_check_at = datetime.utcnow() - timedelta(seconds=1)
+            db.commit()
             provider.get_order.return_value = provider_data
             assert reconcile_huihui_org_notices(db) == 0
-            assert db.get(HuihuiOrgPaymentNotice, order_no).attempts == 2
+            assert db.get(HuihuiOrgPaymentNotice, order_no).attempts == 1
             assert db.query(TokenPaymentOrder).filter(TokenPaymentOrder.order_no == order_no).one().status == "pending"
             notice.next_check_at = datetime.utcnow() - timedelta(seconds=1)
             db.commit()